linux-kernel - Re: [PATCH v2 5/6] power: bq27xxx_battery: Add support for additional bq27xxx family devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150802073853.GD3720@amd>
Date:	Sun, 2 Aug 2015 09:38:53 +0200
From:	Pavel Machek <pavel@....cz>
To:	"Andrew F. Davis" <afd@...com>
Cc:	Pali Rohár <pali.rohar@...il.com>,
	Sebastian Reichel <sre@...nel.org>,
	Dmitry Eremin-Solenikov <dbaryshkov@...il.com>,
	David Woodhouse <dwmw2@...radead.org>,
	Dan Murphy <dmurphy@...com>, linux-pm@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 5/6] power: bq27xxx_battery: Add support for
 additional bq27xxx family devices


> +#define INVALID_REG_ADDR	0xff

> +static u8 bq27000_regs[] = {
> +	0x00,	/* CONTROL	*/
> +	0x06,	/* TEMP		*/
> +	0xff,	/* INT TEMP - NA*/

I'd use the INVALID_REG_ADDR macro here.. Makes it more clear what is
going on (and you may change it to -1 in future, for example).

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/