linux-kernel - Re: [PATCH v3 1/2] iio: mmc35240: minor change to improve code readibility

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55BE46E3.8010006@kernel.org>
Date:	Sun, 2 Aug 2015 17:35:47 +0100
From:	Jonathan Cameron <jic23@...nel.org>
To:	Teodora Baluta <teodora.baluta@...el.com>
Cc:	knaack.h@....de, lars@...afoo.de, pmeerw@...erw.net,
	daniel.baluta@...el.com, dan.carpenter@...cle.com,
	linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/2] iio: mmc35240: minor change to improve code
 readibility

On 31/07/15 15:27, Teodora Baluta wrote:
> This patch changes two variables to arrays to improve code readibility.
> 
> Signed-off-by: Teodora Baluta <teodora.baluta@...el.com>
After a brief argument with myself (see inline).
Applied to the togreg branch of iio.git

Thanks,

Jonathan
> ---
>  drivers/iio/magnetometer/mmc35240.c | 26 +++++++++++++-------------
>  1 file changed, 13 insertions(+), 13 deletions(-)
> 
> diff --git a/drivers/iio/magnetometer/mmc35240.c b/drivers/iio/magnetometer/mmc35240.c
> index 66d8364..a4259bf 100644
> --- a/drivers/iio/magnetometer/mmc35240.c
> +++ b/drivers/iio/magnetometer/mmc35240.c
> @@ -315,31 +315,31 @@ static int mmc35240_read_measurement(struct mmc35240_data *data, __le16 buf[3])
>  static int mmc35240_raw_to_mgauss(struct mmc35240_data *data, int index,
>  				  __le16 buf[], int *val)
>  {
> -	int raw_x, raw_y, raw_z;
> -	int sens_x, sens_y, sens_z;
> +	int raw[3];
> +	int sens[3];
>  	int nfo;
>  
> -	raw_x = le16_to_cpu(buf[AXIS_X]);
> -	raw_y = le16_to_cpu(buf[AXIS_Y]);
> -	raw_z = le16_to_cpu(buf[AXIS_Z]);
A loop perhaps would make it even cleaner?  Maybe not given it would obscure the
enum entries...  Hmm. Perhaps best as is.
> +	raw[AXIS_X] = le16_to_cpu(buf[AXIS_X]);
> +	raw[AXIS_Y] = le16_to_cpu(buf[AXIS_Y]);
> +	raw[AXIS_Z] = le16_to_cpu(buf[AXIS_Z]);
>  
> -	sens_x = mmc35240_props_table[data->res].sens[AXIS_X];
> -	sens_y = mmc35240_props_table[data->res].sens[AXIS_Y];
> -	sens_z = mmc35240_props_table[data->res].sens[AXIS_Z];
> +	sens[AXIS_X] = mmc35240_props_table[data->res].sens[AXIS_X];
> +	sens[AXIS_Y] = mmc35240_props_table[data->res].sens[AXIS_Y];
> +	sens[AXIS_Z] = mmc35240_props_table[data->res].sens[AXIS_Z];
>  
>  	nfo = mmc35240_props_table[data->res].nfo;
>  
>  	switch (index) {
>  	case AXIS_X:
> -		*val = (raw_x - nfo) * 1000 / sens_x;
> +		*val = (raw[AXIS_X] - nfo) * 1000 / sens[AXIS_X];
>  		break;
>  	case AXIS_Y:
> -		*val = (raw_y - nfo) * 1000 / sens_y -
> -			(raw_z - nfo)  * 1000 / sens_z;
> +		*val = (raw[AXIS_Y] - nfo) * 1000 / sens[AXIS_Y] -
> +			(raw[AXIS_Z] - nfo)  * 1000 / sens[AXIS_Z];
>  		break;
>  	case AXIS_Z:
> -		*val = (raw_y - nfo) * 1000 / sens_y +
> -			(raw_z - nfo) * 1000 / sens_z;
> +		*val = (raw[AXIS_Y] - nfo) * 1000 / sens[AXIS_Y] +
> +			(raw[AXIS_Z] - nfo) * 1000 / sens[AXIS_Z];
>  		break;
>  	default:
>  		return -EINVAL;
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/