linux-kernel - Re: [PATCH] Check return code from pdc20621_i2c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAO-S75DznUxvYg9RPcDOaw1H8XK8MuXxFGOARVt-5OtW2_RJnA@mail.gmail.com>
Date:	Sun, 2 Aug 2015 10:55:58 -0700
From:	Tomer Barletz <barletz@...il.com>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc:	tj@...nel.org, linux-ide@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Check return code from pdc20621_i2c_read()

Re-sending in plain-text.

On Sun, Aug 2, 2015 at 4:09 AM, Sergei Shtylyov
<sergei.shtylyov@...entembedded.com> wrote:

>    Please use pr_err() instead. And "0x%d" makes no sense at all, please use "%#x" instead.
>

Yeah, not sure what I was drinking before writing this 0x%d thing...

Regarding the pr_err() - it is not used at all in this file, and
printk() is used instead. Wouldn't it be better to leave it with
printk for this change, then have another change that replaces
printk()s with pr_err()s?


--Tomer


On Sun, Aug 2, 2015 at 10:53 AM, Tomer Barletz <barletz@...il.com> wrote:
>
> On Sun, Aug 2, 2015 at 4:09 AM, Sergei Shtylyov
> <sergei.shtylyov@...entembedded.com> wrote:
>
>>    Please use pr_err() instead. And "0x%d" makes no sense at all, please
>> use "%#x" instead.
>>
>
> Yeah, not sure what I was drinking before writing this 0x%d thing...
>
> Regarding the pr_err() - it is not used at all in this file, and printk() is
> used instead. Wouldn't it be better to leave it with printk for this change,
> then have another change that replaces printk()s with pr_err()s?
>
> --Tomer
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/