linux-kernel - [PATCH v2] HID: hid-input: Fix accessing freed memory during device disconnect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-id: <1438560081-23055-1-git-send-email-k.kozlowski@samsung.com>
Date:	Mon, 03 Aug 2015 09:01:21 +0900
From:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
To:	Jiri Kosina <jkosina@...e.com>, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org
Cc:	Dmitry Torokhov <dmitry.torokhov@...il.com>, sre@...nel.org,
	linux-pm@...r.kernel.org, "H.J. Lu" <hjl.tools@...il.com>,
	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	stable@...r.kernel.org
Subject: [PATCH v2] HID: hid-input: Fix accessing freed memory during device
 disconnect

During unbinding the driver was dereferencing a pointer to memory
already freed by power_supply_unregister().

Driver was freeing its internal description of battery through pointers
stored in power_supply structure. However, because the core owns the
power supply instance, after calling power_supply_unregister() this
memory is freed and the driver cannot access these members.

Fix this by storing the pointer to internal description of battery in a
local variable before calling power_supply_unregister(), so the pointer
remains valid.

Signed-off-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>
Reported-by: H.J. Lu <hjl.tools@...il.com>
Fixes: 297d716f6260 ("power_supply: Change ownership from driver to core")
Cc: <stable@...r.kernel.org>

---
Changes since v1:
1. Re-work idea, use local variable instead of devm-like functions
   (pointed out by Dmitry Torokhov).
2. Adjusted subject and commit message.
---
 drivers/hid/hid-input.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
index 14aebe483219..460faaebaa2c 100644
--- a/drivers/hid/hid-input.c
+++ b/drivers/hid/hid-input.c
@@ -462,12 +462,15 @@ out:

 static void hidinput_cleanup_battery(struct hid_device *dev)
 {
+	struct power_supply_desc *psy_desc;
+
 	if (!dev->battery)
 		return;

+	psy_desc = dev->battery->desc;
 	power_supply_unregister(dev->battery);
-	kfree(dev->battery->desc->name);
-	kfree(dev->battery->desc);
+	kfree(psy_desc->name);
+	kfree(psy_desc);
 	dev->battery = NULL;
 }
 #else  /* !CONFIG_HID_BATTERY_STRENGTH */
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/