linux-kernel - Re: [TRIVIAL PATCH] block: Correct misuses of 0x%<decimal>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <mqd614w6dor.fsf@c203.arch.suse.de>
Date:	Mon, 03 Aug 2015 09:20:20 +0200
From:	Johannes Thumshirn <jthumshirn@...e.de>
To:	Joe Perches <joe@...ches.com>
Cc:	Don Brace <don.brace@...s.com>, linux-kernel@...r.kernel.org,
	iss_storagedev@...com, storagedev@...s.com,
	linux-scsi <linux-scsi@...r.kernel.org>
Subject: Re: [TRIVIAL PATCH] block: Correct misuses of 0x%<decimal>

Joe Perches <joe@...ches.com> writes:

> Correct misuse of 0x%d in logging messages.
>
> Signed-off-by: Joe Perches <joe@...ches.com>
> ---
>  drivers/block/DAC960.c | 4 ++--
>  drivers/block/cciss.c  | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/block/DAC960.c b/drivers/block/DAC960.c
> index 811e11c..d9b32f2 100644
> --- a/drivers/block/DAC960.c
> +++ b/drivers/block/DAC960.c
> @@ -2954,7 +2954,7 @@ DAC960_DetectController(struct pci_dev *PCI_Device,
>         case DAC960_PD_Controller:
>           if (!request_region(Controller->IO_Address, 0x80,
>                               Controller->FullModelName)) {
> -               DAC960_Error("IO port 0x%d busy for Controller at\n",
> +               DAC960_Error("IO port 0x%x busy for Controller at\n",
>                              Controller, Controller->IO_Address);
>                 goto Failure;
>           }
> @@ -2990,7 +2990,7 @@ DAC960_DetectController(struct pci_dev *PCI_Device,
>         case DAC960_P_Controller:
>           if (!request_region(Controller->IO_Address, 0x80,
>                               Controller->FullModelName)){
> -               DAC960_Error("IO port 0x%d busy for Controller at\n",
> +               DAC960_Error("IO port 0x%x busy for Controller at\n",
>                              Controller, Controller->IO_Address);
>                 goto Failure;
>           }
> diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c
> index 0422c47..2758982 100644
> --- a/drivers/block/cciss.c
> +++ b/drivers/block/cciss.c
> @@ -3854,7 +3854,7 @@ static void print_cfg_table(ctlr_info_t *h)
>                readl(&(tb->HostWrite.CoalIntDelay)));
>         dev_dbg(&h->pdev->dev, "   Coalesce Interrupt Count = 0x%x\n",
>                readl(&(tb->HostWrite.CoalIntCount)));
> -       dev_dbg(&h->pdev->dev, "   Max outstanding commands = 0x%d\n",
> +       dev_dbg(&h->pdev->dev, "   Max outstanding commands = 0x%x\n",
>                readl(&(tb->CmdsOutMax)));
>         dev_dbg(&h->pdev->dev, "   Bus Types = 0x%x\n",
>                 readl(&(tb->BusTypes)));
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reviewed-by: Johannes Thumshirn <jthumshirn@...e.de>

-- 
Johannes Thumshirn                                           Storage
jthumshirn@...e.de                                 +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600  D0D0 0393 969D 2D76 0850
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/