linux-kernel - RE: [PATCH v2 1/2] powerpc/mpc85xx: Create dts components for the FSL QorIQ DPAA FMan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 3 Aug 2015 07:36:22 +0000
From:	Liberman Igal <Igal.Liberman@...escale.com>
To:	Scott Wood <scottwood@...escale.com>
CC:	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
	Madalin-Cristian Bucur <madalin.bucur@...escale.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2 1/2] powerpc/mpc85xx: Create dts components for the FSL
 QorIQ DPAA FMan



Regards,
Igal Liberman.

> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Thursday, July 30, 2015 11:00 PM
> To: Liberman Igal-B31950
> Cc: devicetree@...r.kernel.org; linuxppc-dev@...ts.ozlabs.org; Bucur
> Madalin-Cristian-B32716; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH v2 1/2] powerpc/mpc85xx: Create dts components for
> the FSL QorIQ DPAA FMan
> 
> On Thu, 2015-07-30 at 07:32 +0300, Igal.Liberman wrote:
> > +fman0:  fman@...000{
> > +     #address-cells = <1>;
> > +     #size-cells = <1>;
> > +     cell-index = <0>;
> > +     compatible = "fsl,fman";
> > +     ranges = <0 0x400000 0x100000>;
> > +     reg = <0x400000 0x100000>;
> > +     interrupts = <96 2 0 0>, <16 2 1 1>;
> > +     clocks = <&clockgen 3 0>;
> > +     clock-names = "fm0clk";
> 
> clock-names should be "fmanclk" as per the binding.  And why would you
> want the driver to have to encode the fman index into the name in order to
> look the clock up by name?
> 

Well, yes, this should be "fmanclk". The driver doesn't need to know the index.
I'll fix that and re-submit.

Igal.

> -Scott