linux-kernel - Re: [PATCH 4/6] iio: event: Add missing fields in kernel docs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 03 Aug 2015 11:05:25 +0200
From:	Lars-Peter Clausen <lars@...afoo.de>
To:	Hartmut Knaack <knaack.h@....de>,
	Jonathan Cameron <jic23@...nel.org>,
	Cristina Opriceana <cristina.opriceana@...il.com>
CC:	pmeerw@...erw.net, linux-iio@...r.kernel.org,
	linux-kernel@...r.kernel.org, daniel.baluta@...el.com
Subject: Re: [PATCH 4/6] iio: event: Add missing fields in kernel docs

On 08/02/2015 09:43 PM, Hartmut Knaack wrote:
> Jonathan Cameron schrieb am 02.08.2015 um 19:33:
>> On 24/07/15 14:21, Cristina Opriceana wrote:
>>> Fix kernel docs warnings by adding the missing fields,
>>> each with its associated description.
>>>
>>> Signed-off-by: Cristina Opriceana <cristina.opriceana@...il.com>
>> Applied.  Thanks
>>
>> Jonathan
>>> ---
>>>  drivers/iio/industrialio-event.c | 6 ++++++
>>>  1 file changed, 6 insertions(+)
>>>
>>> diff --git a/drivers/iio/industrialio-event.c b/drivers/iio/industrialio-event.c
>>> index 894d813..b2f63f9 100644
>>> --- a/drivers/iio/industrialio-event.c
>>> +++ b/drivers/iio/industrialio-event.c
>>> @@ -32,6 +32,7 @@
>>>   * @dev_attr_list:	list of event interface sysfs attribute
>>>   * @flags:		file operations related flags including busy flag.
>>>   * @group:		event interface sysfs attribute group
>>> + * @read_lock:		lock to protect kfifo read operations
>>>   */
>>>  struct iio_event_interface {
>>>  	wait_queue_head_t	wait;
>>> @@ -75,6 +76,11 @@ EXPORT_SYMBOL(iio_push_event);
>>>  
>>>  /**
>>>   * iio_event_poll() - poll the event queue to find out if it has data
>>> + * @filep:	File structure pointer to identify the device
>>> + * @wait:	Poll table pointer to add the wait queue on
>>> + *
>>> + * Return: (POLLIN | POLLRDNORM) if data is available for reading
>>> + *	   or a negative error code on failure
> 
> This can also return 0 if no data is available.
> 
> Actually, being unsigned int, the intended negative error code won't
> appear - ouch! Any volunteers to address this issue?

Sorry, my fault. It looks like the poll() callback can't return a error. So
if no device is bound we should just return 0.

- Lars

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/