linux-kernel - Re: [PATCH] iio: industrialio-buffer: Fix iio_buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 3 Aug 2015 13:44:00 +0300
From:	Daniel Baluta <daniel.baluta@...el.com>
To:	Cristina Opriceana <cristina.opriceana@...il.com>
Cc:	Jonathan Cameron <jic23@...nel.org>,
	Hartmut Knaack <knaack.h@....de>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Peter Meerwald <pmeerw@...erw.net>,
	"linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Daniel Baluta <daniel.baluta@...el.com>
Subject: Re: [PATCH] iio: industrialio-buffer: Fix iio_buffer_poll return value

On Mon, Aug 3, 2015 at 1:37 PM, Cristina Opriceana
<cristina.opriceana@...il.com> wrote:
> Change return value to 0 if no device is bound since
> unsigned int cannot support negative error codes.
>
> Signed-off-by: Cristina Opriceana <cristina.opriceana@...il.com>

Fixes: f18e7a068 ("iio: Return -ENODEV for file operations if the
device has been unregistered")

> ---
>  drivers/iio/industrialio-buffer.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/industrialio-buffer.c b/drivers/iio/industrialio-buffer.c
> index faed6ef..e8e87cf 100644
> --- a/drivers/iio/industrialio-buffer.c
> +++ b/drivers/iio/industrialio-buffer.c
> @@ -155,7 +155,9 @@ ssize_t iio_buffer_read_first_n_outer(struct file *filp, char __user *buf,
>   *             a wait queue
>   *
>   * Return: (POLLIN | POLLRDNORM) if data is available for reading
> - *        or 0 for other cases
> + *        and 0 for other cases, e.g. no device is bound or no
> + *        hardware fifo flush could be triggered.
> + *
>   */
>  unsigned int iio_buffer_poll(struct file *filp,
>                              struct poll_table_struct *wait)
> @@ -164,7 +166,7 @@ unsigned int iio_buffer_poll(struct file *filp,
>         struct iio_buffer *rb = indio_dev->buffer;
>
>         if (!indio_dev->info)
> -               return -ENODEV;
> +               return 0;
>
>         poll_wait(filp, &rb->pollq, wait);
>         if (iio_buffer_ready(indio_dev, rb, rb->watermark, 0))
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/