linux-kernel - Re: [PATCH] Staging: rts5208: Fix code indentation warning as detected by checkpatch.pl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150803120945.GX5180@mwanda>
Date:	Mon, 3 Aug 2015 15:09:45 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Joe Perches <joe@...ches.com>
Cc:	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"tinajohnson.1234@...il.com" <tinajohnson.1234@...il.com>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"lambert.quentin@...il.com" <lambert.quentin@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"fabio.falzoi84@...il.com" <fabio.falzoi84@...il.com>,
	"roxanagabriela10@...il.com" <roxanagabriela10@...il.com>,
	"vatikaharlalka@...il.com" <vatikaharlalka@...il.com>,
	"Shah, Yash (Y.)" <yshah1@...teon.com>,
	"contact@...othyleung.co" <contact@...othyleung.co>
Subject: Re: [PATCH] Staging: rts5208: Fix code indentation warning as
 detected by checkpatch.pl

On Mon, Aug 03, 2015 at 04:41:40AM -0700, Joe Perches wrote:
> On Mon, 2015-08-03 at 14:33 +0300, Dan Carpenter wrote:
> > On Mon, Aug 03, 2015 at 11:18:31AM +0000, Shah, Yash (Y.) wrote:
> > > From: Yash Shah <yshah1@...teon.com>
> > > 
> > > Fixed code indentation warning as detected by checkpatch.pl.
> > > 
> > > Signed-off-by: Yash Shah <yshah1@...teon.com>
> > 
> > Defines aren't allowed in .c files anyway.
> 
> The kernel source tree disagrees with you
> 
> $ git grep "^\s*#\s*define\b" -- "*.c" | wc -l
> 175830

Duh.  Sorry.  I meant ifdefs.  I'm sure you can find lots of examples
of those too, but this code would be cleaner without the ifdefs.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/