linux-kernel - RE: [PATCH v3 4/6] power: da9150: Add DT bindings documentation for Fuel-Gauge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2E89032DDAA8B9408CB92943514A0337AB5690D0@SW-EX-MBX01.diasemi.com>
Date:	Mon, 3 Aug 2015 15:24:02 +0000
From:	"Opensource [Adam Thomson]" <Adam.Thomson.Opensource@...semi.com>
To:	Sebastian Reichel <sre@...nel.org>,
	"Opensource [Adam Thomson]" <Adam.Thomson.Opensource@...semi.com>
CC:	Lee Jones <lee.jones@...aro.org>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Dmitry Eremin-Solenikov <dbaryshkov@...il.com>,
	David Woodhouse <dwmw2@...radead.org>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Support Opensource" <Support.Opensource@...semi.com>
Subject: RE: [PATCH v3 4/6] power: da9150: Add DT bindings documentation for
 Fuel-Gauge

On July 24, 2015 23:01, Sebastian Reichel wrote:

> Hi,
> 
> On Tue, Jul 07, 2015 at 05:34:21PM +0100, Adam Thomson wrote:
> > diff --git a/Documentation/devicetree/bindings/power/da9150-fg.txt
> b/Documentation/devicetree/bindings/power/da9150-fg.txt
> > new file mode 100644
> > index 0000000..c3c76eb
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/power/da9150-fg.txt
> > @@ -0,0 +1,23 @@
> > +Dialog Semiconductor DA9150 Fuel-Gauge Power Supply bindings
> > +
> > +Required properties:
> > +- compatible: "dlg,da9150-fg" for DA9150 Fuel-Gauge Power Supply
>                   ^^^^^^^^^^^^^
> 
> s/dlg,da9150-fg/dlg,da9150-fuel-gauge/g
> 

Ok, can do.

> > +Optional properties:
> > +- dlg,update-interval: Interval time (milliseconds) between battery level checks.
> > +- dlg,warn-soc-level: Battery discharge level (%) where warning event raised.
> > +      [1 - 100]
> > +- dlg,crit-soc-level: Battery discharge level (%) where critical event raised.
> > +  This value should be lower than the warning level.
> > +      [1 - 100]
> > +
> > +
> > +Example:
> > +
> > +	da9150-fg {
> 
> Make this just "fuel-gauge".

No problem.

> 
> > +		compatible = "dlg,da9150-fg";
>                       ^^^^^^^^^^^^^
> 
> here too ;)

Consider it done. :)

> 
> > +
> > +		dlg,update-interval = <10000>;
> > +		dlg,warn-soc-level = /bits/ 8 <15>;
> > +		dlg,crit-soc-level = /bits/ 8 <5>;
> > +	};
> 
> -- Sebastian