linux-kernel - Re: [TRIVIAL PATCH] sgi-gru: Correct misuse of %0x<decimal>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1438615728.30149.31.camel@perches.com>
Date:	Mon, 03 Aug 2015 08:28:48 -0700
From:	Joe Perches <joe@...ches.com>
To:	Dimitri Sivanich <sivanich@....com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [TRIVIAL PATCH] sgi-gru: Correct misuse of %0x<decimal>

On Mon, 2015-08-03 at 08:10 -0500, Dimitri Sivanich wrote:
> This should be %d, not 0x%x.

I don't care one way or the other, but
please fix it so it matches.


> > diff --git a/drivers/misc/sgi-gru/grumain.c b/drivers/misc/sgi-gru/grumain.c
> > index ae16c8c..a1ce324 100644
> > --- a/drivers/misc/sgi-gru/grumain.c
> > +++ b/drivers/misc/sgi-gru/grumain.c
> > @@ -283,7 +283,7 @@ static void gru_unload_mm_tracker(struct gru_state *gru,
> >         spin_lock(&gru->gs_asid_lock);
> >         BUG_ON((asids->mt_ctxbitmap & ctxbitmap) != ctxbitmap);
> >         asids->mt_ctxbitmap ^= ctxbitmap;
> > -       gru_dbg(grudev, "gid %d, gts %p, gms %p, ctxnum 0x%d, asidmap 0x%lx\n",
> > +       gru_dbg(grudev, "gid %d, gts %p, gms %p, ctxnum 0x%x, asidmap 0x%lx\n",
> >                 gru->gs_gid, gts, gms, gts->ts_ctxnum, gms->ms_asidmap[0]);
> >         spin_unlock(&gru->gs_asid_lock);
> >         spin_unlock(&gms->ms_asid_lock);

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/