linux-kernel - Re: [PATCH 2/2] sched: Trace point sched_stat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150803184338.GZ25159@twins.programming.kicks-ass.net>
Date:	Mon, 3 Aug 2015 20:43:38 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	yangoliver <yang_oliver@...mail.com>, mingo@...hat.com,
	linux-kernel@...r.kernel.org, Yong Yang <yangoliver@...il.com>
Subject: Re: [PATCH 2/2] sched: Trace point sched_stat_sleep should cover
 iowait case

On Mon, Aug 03, 2015 at 01:35:28PM -0400, Steven Rostedt wrote:
> On Mon, 27 Jul 2015 09:11:52 -0400
> yangoliver <yang_oliver@...mail.com> wrote:
> 
> > Per sched_stat_sleep definition in sched.h, it should include
> > iowait case. This can also relect the design of sum_sleep_runtime
> > statistic, as this counter also includes the io_wait.
> > 
> > Signed-off-by: Yong Yang <yangoliver@...il.com>
> > ---
> >  kernel/sched/fair.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> > index d113c3b..85677bf 100644
> > --- a/kernel/sched/fair.c
> > +++ b/kernel/sched/fair.c
> > @@ -3018,6 +3018,8 @@ static void enqueue_sleeper(struct cfs_rq *cfs_rq, struct sched_entity *se)
> >  		se->statistics.sum_sleep_runtime += delta;
> >  
> >  		if (tsk) {
> > +			trace_sched_stat_sleep(tsk, delta);
> > +
> >  			if (tsk->in_iowait) {
> >  				se->statistics.iowait_sum += delta;
> >  				se->statistics.iowait_count++;
> 

No, that's broken in two ways. Firstly you don't change semantics of
stuff just because of a comment and secondly iowait has nothing what all
to do with INTERRUPTIBLE/sleep vs UNINTERRUPTIBLE/blocked.

And wtf are you doing sending sched patches and not Cc maintainers.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/