linux-kernel - Re: [PATCH 03/15] drivers: devfreq: Drop unlikely before IS_ERR(_OR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-id: <1641980442.342501438578642999.JavaMail.weblogic@epmlwas06d>
Date:	Mon, 03 Aug 2015 05:10:44 +0000 (GMT)
From:	MyungJoo Ham <myungjoo.ham@...sung.com>
To:	Viresh Kumar <viresh.kumar@...aro.org>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>
Cc:	"linaro-kernel@...ts.linaro.org" <linaro-kernel@...ts.linaro.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	박경민 <kyungmin.park@...sung.com>,
	"open list:DEVICE FREQUENCY (DEVFREQ)" <linux-pm@...r.kernel.org>
Subject: Re: [PATCH 03/15] drivers: devfreq: Drop unlikely before
 IS_ERR(_OR_NULL)

> IS_ERR(_OR_NULL) already contain an 'unlikely' compiler flag and there
> is no need to do that again from its callers. Drop it.
> 
> Signed-off-by: Viresh Kumar <viresh.kumar@...aro.org>

@ from include/linux/err.h
#define IS_ERR_VALUE(x) unlikely((x) >= (unsigned long)-MAX_ERRNO)
...
static inline bool __must_check IS_ERR_OR_NULL(__force const void *ptr)
{
	return !ptr || IS_ERR_VALUE((unsigned long)ptr);
}

"!ptr" appears not covered with IS_ERR_OR_NULL.
(only the IS_ERR part seems covered)


Cheers,
MyungJoo