linux-kernel - Re: [PATCH] aer: add cond_resched to aer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150803224418.GC11144@google.com>
Date:	Mon, 3 Aug 2015 17:44:18 -0500
From:	Bjorn Helgaas <bhelgaas@...gle.com>
To:	Spencer Baugh <sbaugh@...ern.com>
Cc:	Yijing Wang <wangyijing@...wei.com>, Joern Engel <joern@...fs.org>,
	"open list:PCI SUBSYSTEM" <linux-pci@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>,
	Joern Engel <joern@...estorage.com>,
	Spencer Baugh <Spencer.baugh@...estorage.com>
Subject: Re: [PATCH] aer: add cond_resched to aer_isr

Hi Spencer & Joern,

On Thu, Jul 23, 2015 at 02:54:32PM -0700, Spencer Baugh wrote:
> From: Joern Engel <joern@...fs.org>
> 
> Multiple nested loops.  I have observed 590ms scheduler latency caused
> by this loop and interrupts.  Interrupts were responsible for 190ms, the
> rest could have been avoided with a cond_resched.

I'm not disagreeing with this patch, but it would be helpful to sketch
the outline of the "multiple nested loop" problem here.  This might be
a hint that we could do even better by rethinking the algorithm reduce
the nesting.

> Signed-off-by: Joern Engel <joern@...fs.org>
> Signed-off-by: Spencer Baugh <sbaugh@...ern.com>
> ---
>  drivers/pci/pcie/aer/aerdrv_core.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/pcie/aer/aerdrv_core.c b/drivers/pci/pcie/aer/aerdrv_core.c
> index 9803e3d..32b1b5c 100644
> --- a/drivers/pci/pcie/aer/aerdrv_core.c
> +++ b/drivers/pci/pcie/aer/aerdrv_core.c
> @@ -780,8 +780,10 @@ void aer_isr(struct work_struct *work)
>  	struct aer_err_source uninitialized_var(e_src);
>  
>  	mutex_lock(&rpc->rpc_mutex);
> -	while (get_e_source(rpc, &e_src))
> +	while (get_e_source(rpc, &e_src)) {
>  		aer_isr_one_error(p_device, &e_src);
> +		cond_resched();
> +	}
>  	mutex_unlock(&rpc->rpc_mutex);
>  
>  	wake_up(&rpc->wait_release);
> -- 
> 2.5.0.rc3
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/