linux-kernel - Re: [PATCH] compiler.h: cast away attributes in WRITE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150804104723.GP25159@twins.programming.kicks-ass.net>
Date:	Tue, 4 Aug 2015 12:47:23 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Christian Borntraeger <borntraeger@...ibm.com>
Cc:	Andrey Konovalov <andreyknvl@...gle.com>,
	Ingo Molnar <mingo@...nel.org>,
	Paul McKenney <paulmck@...ux.vnet.ibm.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] compiler.h: cast away attributes in WRITE_ONCE magic

On Tue, Aug 04, 2015 at 12:33:04PM +0200, Christian Borntraeger wrote:
> Am 04.08.2015 um 11:20 schrieb Peter Zijlstra:
> > On Tue, Aug 04, 2015 at 09:55:48AM +0200, Christian Borntraeger wrote:
> >> kernel build bot showed a warning triggered by commit
> >> 76695af20c01 ("locking, arch: use WRITE_ONCE()/READ_ONCE() in
> >> smp_store_release()/smp_load_acquire()"). Turns out that sparse
> >> does not like WRITE_ONCE accessing elements from the (sparse)
> >> rcu address space.
> >>
> >> fs/afs/inode.c:448:9: sparse: incorrect type in initializer (different address spaces)
> >> fs/afs/inode.c:448:9:    expected struct afs_permits *__val
> >> fs/afs/inode.c:448:9:    got void [noderef] <asn:4>*<noident>
> >>
> >> Solution is to force cast away the sparse attributes for the initializer
> >> of the union in WRITE_SAME. As this now gets too long, lets split
> > 
> > WRITE_ONCE, right?
> 
> Indeed, guess what area I was looking into before....;-)
> 
> Shall I respin or can you fixup.

I've already fixed it. Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/