linux-kernel - Re: [PATCH v2 04/10] thermal: Fix thermal_zone_of_sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9hha8u7mi7a.fsf@e105922-lin.cambridge.arm.com>
Date:	Tue, 04 Aug 2015 12:00:41 +0100
From:	Punit Agrawal <punit.agrawal@....com>
To:	Guenter Roeck <linux@...ck-us.net>
Cc:	linux-pm@...r.kernel.org, lm-sensors@...sensors.org,
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
	liviu.dudau@....com, Eduardo Valentin <edubezval@...il.com>,
	Zhang Rui <rui.zhang@...el.com>
Subject: Re: [PATCH v2 04/10] thermal: Fix thermal_zone_of_sensor_register to match documentation

Guenter Roeck <linux@...ck-us.net> writes:

> On 08/03/2015 08:22 AM, Punit Agrawal wrote:
>> thermal_zone_of_sensor_register is documented as returning a pointer
>> to either a valid thermal_zone_device on success, or a corresponding
>> ERR_PTR() value.
>>
>> In contrast, the function returns NULL when THERMAL_OF is configured
>> off. Fix this.
>>
>> Signed-off-by: Punit Agrawal <punit.agrawal@....com>
>> Cc: Guenter Roeck <linux@...ck-us.net>
>> Cc: Eduardo Valentin <edubezval@...il.com>
>> Cc: Zhang Rui <rui.zhang@...el.com>
>
> Acked-by: Guenter Roeck <linux@...ck-us.net>
>

Thanks, Guenter.

>> ---
>>   include/linux/thermal.h | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/linux/thermal.h b/include/linux/thermal.h
>> index 037e9df..a47b34a 100644
>> --- a/include/linux/thermal.h
>> +++ b/include/linux/thermal.h
>> @@ -364,7 +364,7 @@ static inline struct thermal_zone_device *
>>   thermal_zone_of_sensor_register(struct device *dev, int id, void *data,
>>   				const struct thermal_zone_of_device_ops *ops)
>>   {
>> -	return NULL;
>> +	return ERR_PTR(-ENOSYS);
>>   }
>>
>>   static inline
>>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/