linux-kernel - Re: 4.0.8->4.1.3 : after resume from s2ram both internal and external display of a docked ThinkPad ate black

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 4 Aug 2015 14:29:44 +0200
From:	Toralf Förster <toralf.foerster@....de>
To:	Pavel Machek <pavel@....cz>
Cc:	intel-gfx <intel-gfx@...ts.freedesktop.org>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	Dave Airlie <airlied@...hat.com>
Subject: Re: 4.0.8->4.1.3 : after resume from s2ram both internal and external
 display of a docked ThinkPad ate black

On 08/02/2015 09:43 AM, Pavel Machek wrote:
> Any chance to bisect it?
Did it.

FWIW: the mentioned commit was introduced between 3.18 and 3.19.
But my system (hardened 64 bit Gentoo) did not suffer from it till version 4.0.8.
The hardened kernel 4.1.x was the first where the bug was visible at my docked environment  too.



commit e7d6f7d708290da1b7c92f533444b042c79412e0
Author: Dave Airlie <airlied@...hat.com>
Date:   Mon Dec 8 13:23:37 2014 +1000

    drm/i915: resume MST after reading back hw state

    Otherwise the MST resume paths can hit DPMS paths
    which hit state checker paths, which hit WARN_ON,
    because the state checker is inconsistent with the
    hw.

    This fixes a bunch of WARN_ON's on resume after
    undocking.

    Signed-off-by: Dave Airlie <airlied@...hat.com>
    Reviewed-by: Daniel Vetter <daniel.vetter@...ll.ch>
    Cc: stable@...r.kernel.org
    Signed-off-by: Jani Nikula <jani.nikula@...el.com>

diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index 1e9c136..f990ab4 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -706,11 +706,12 @@ static int i915_drm_resume(struct drm_device *dev)
                        dev_priv->display.hpd_irq_setup(dev);
                spin_unlock_irq(&dev_priv->irq_lock);

-               intel_dp_mst_resume(dev);
                drm_modeset_lock_all(dev);
                intel_modeset_setup_hw_state(dev, true);
                drm_modeset_unlock_all(dev);

+               intel_dp_mst_resume(dev);
+
                /*
                 * ... but also need to make sure that hotplug processing
                 * doesn't cause havoc. Like in the driver load code we don't


-- 
Toralf, pgp key: 872AE508 0076E94E
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/