linux-kernel - Re: [PATCH v3] HID: hid-input: Fix accessing freed memory during device disconnect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1508041547250.27871@pobox.suse.cz>
Date:	Tue, 4 Aug 2015 15:47:49 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.com>
To:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
cc:	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	Dmitry Torokhov <dmitry.torokhov@...il.com>, sre@...nel.org,
	linux-pm@...r.kernel.org, "H.J. Lu" <hjl.tools@...il.com>,
	stable@...r.kernel.org
Subject: Re: [PATCH v3] HID: hid-input: Fix accessing freed memory during
 device disconnect

On Mon, 3 Aug 2015, Krzysztof Kozlowski wrote:

> During unbinding the driver was dereferencing a pointer to memory
> already freed by power_supply_unregister().
> 
> Driver was freeing its internal description of battery through pointers
> stored in power_supply structure. However, because the core owns the
> power supply instance, after calling power_supply_unregister() this
> memory is freed and the driver cannot access these members.
> 
> Fix this by storing the pointer to internal description of battery in a
> local variable before calling power_supply_unregister(), so the pointer
> remains valid.
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>
> Reported-by: H.J. Lu <hjl.tools@...il.com>
> Fixes: 297d716f6260 ("power_supply: Change ownership from driver to core")
> Cc: <stable@...r.kernel.org>

Applied to for-4.2/upstream-fixes-devm-fixed, and thanks again Dmitry for 
catching my mistake.

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/