linux-kernel - Re: [PATCH v5] powerpc/rcpm: add RCPM driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1438656368.10331.0@remotesmtp.freescale.net>
Date:	Tue, 4 Aug 2015 10:46:08 +0800
From:	Chenhui Zhao <chenhui.zhao@...escale.com>
To:	Scott Wood <scottwood@...escale.com>
CC:	<Yuantian.Tang@...escale.com>, <b07421@...escale.com>,
	<linuxppc-dev@...ts.ozlabs.org>, <linux-kernel@...r.kernel.org>,
	<devicetree@...r.kernel.org>
Subject: Re: [PATCH v5] powerpc/rcpm: add RCPM driver



On Tue, Aug 4, 2015 at 4:23 AM, Scott Wood <scottwood@...escale.com> 
wrote:
> On Mon, 2015-08-03 at 19:14 +0800, Chenhui Zhao wrote:
>>  On Sat, Aug 1, 2015 at 8:45 AM, Scott Wood <scottwood@...escale.com>
>>  wrote:
>>  > On Fri, 2015-06-26 at 15:44 +0800,  
>> Yuantian.Tang@...escale.comwrote:
>>  > >  +static void rcpm_v1_set_ip_power(bool enable, u32 *mask)
>>  > >  +{
>>  > >  +     if (enable)
>>  > >  +             setbits32(&rcpm_v1_regs->ippdexpcr, *mask);
>>  > >  +     else
>>  > >  +             clrbits32(&rcpm_v1_regs->ippdexpcr, *mask);
>>  > >  +}
>>  > >  +
>>  > >  +static void rcpm_v2_set_ip_power(bool enable, u32 *mask)
>>  > >  +{
>>  > >  +     if (enable)
>>  > >  +             setbits32(&rcpm_v2_regs->ippdexpcr[0], *mask);
>>  > >  +     else
>>  > >  +             clrbits32(&rcpm_v2_regs->ippdexpcr[0], *mask);
>>  > >  +}
>>  >
>>  > Why do these take "u32 *mask" instead of "u32 mask"?
>>  >
>>  > -Scott
>> 
>>  I think it can be used in the case where there are several mask 
>> values.
> 
> When would that be?
> 
> -Scott

So far, only use one register, even though the register name is 
"IPPDEXPCRn" (has "n" suffix) in T4 RM.

OK. Just change the parameter to "u32 mask".

-Chenhui

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/