linux-kernel - Re: [PATCH net-next 4/4] net: dsa: mv88e6xxx: refactor FDB routines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150804160300.GB28673@lunn.ch>
Date:	Tue, 4 Aug 2015 18:03:00 +0200
From:	Andrew Lunn <andrew@...n.ch>
To:	Vivien Didelot <vivien.didelot@...oirfairelinux.com>
Cc:	netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
	Guenter Roeck <linux@...ck-us.net>,
	Florian Fainelli <f.fainelli@...il.com>,
	Scott Feldman <sfeldma@...il.com>,
	Jiri Pirko <jiri@...nulli.us>, linux-kernel@...r.kernel.org,
	kernel@...oirfairelinux.com
Subject: Re: [PATCH net-next 4/4] net: dsa: mv88e6xxx: refactor FDB routines

On Tue, Aug 04, 2015 at 02:33:38AM -0400, Vivien Didelot wrote:
> Refactor mv88e6xxx_port_fdb_{add,del,getnext} to respect the new DSA
> switch driver FDB access routines.
> 
> The Marvell 88E6xxx switches support up to 4094 FIDs (from 1 to 0xfff;
> FID 0 means that multiple address databases are not being used). So
> change the fid_mask for a fid_bitmap of 4096 bits.
> 
> FIDs 1 to num_ports will be reserved for non-bridged ports and bridge
> groups (a bridge group gets the FID of its first member). The remaining
> bits will then be used for VLANs.
> 
> Also do not consider an address (yet) if it is trunk mapped.
> 
> This change is a need to welcome the future support for hardware VLANs.

This patch seems to contain more than one logical set of changes. That
is making it hard to review. Can you split it up a bit.

The GLOBAL_ATU_DATA_TRUNK stuff can be in a patch of its own.
unsigned char *addr to u8 addr[ETH_ALEN].
The change fid_mask to fid_bitmap
...
...
The refactoring

Basically, we want to see lots of little patches which are obvious
correct, rather than one big patch where it is not obvious.

Thanks
	Andrew
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/