lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 04 Aug 2015 19:04:36 +0200 From: Robert Jarzmik <robert.jarzmik@...e.fr> To: Andrew Morton <akpm@...ux-foundation.org>, Jens Axboe <axboe@...nel.dk> Cc: Russell King - ARM Linux <linux@....linux.org.uk>, Guennadi Liakhovetski <g.liakhovetski@....de>, Mauro Carvalho Chehab <mchehab@....samsung.com>, linux-kernel@...r.kernel.org, linux-media@...r.kernel.org Subject: Re: [RFC PATCH v2] lib: scatterlist: add sg splitting function Andrew Morton <akpm@...ux-foundation.org> writes: >> include/linux/scatterlist.h | 5 ++ >> lib/scatterlist.c | 189 ++++++++++++++++++++++++++++++++++++++++++++ >> 2 files changed, 194 insertions(+) > > It's quite a bit of code for a fairly specialised thing. How ugly > would it be to put this in a new .c file and have subsystems select it > in Kconfig? I have no idea about the "ugliness", but why not ... If nobody objects, and in order to submit a proper patch, there are decisions to make : - what will be the scope of this new .c file ? - only sg_plit() ? - all sg specialized functions, ie. sg_lib.c ? - will include/linux/scatterlist.h have an "ifdefed" portion for what X.c offers ? - what naming for X.c and the config entry ? What about adding this to lib/Makefile, and one ifdef to scatterlist.h ? : obj-$(CONFIG_SG_LIB) += sg_lib.o Cheers. -- Robert -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists