lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 4 Aug 2015 15:00:01 -0700 From: "Luis R. Rodriguez" <mcgrof@...not-panic.com> To: gregkh@...uxfoundation.org, ming.lei@...onical.com Cc: corbet@....net, linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org, dwmw2@...radead.org, dhowells@...hat.com, seth.forshee@...onical.com, rusty@...tcorp.com.au, mmarek@...e.cz, mjg59@...f.ucam.org, kyle@...nel.org, linux-security-module@...r.kernel.org, keyrings@...ux-nfs.org, "Luis R. Rodriguez" <mcgrof@...e.com>, Andrew Morton <akpm@...ux-foundation.org>, Kees Cook <keescook@...omium.org>, Casey Schaufler <casey@...aufler-ca.com>, Takashi Iwai <tiwai@...e.de>, Vojtěch Pavlík <vojtech@...e.cz> Subject: [PATCH 1/4] firmware: generalize "firmware" as "system data" helpers From: "Luis R. Rodriguez" <mcgrof@...e.com> Historically firmware_class code was added to help get device driver firmware binaries but these days request_firmware*() helpers are being repurposed for general system data needed by the kernel. Annotate this before we extend firmare_class more, as this is expected. We want to generalize the code as much as possible. Cc: Rusty Russell <rusty@...tcorp.com.au> Cc: Andrew Morton <akpm@...ux-foundation.org> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org> Cc: David Howells <dhowells@...hat.com> Cc: Kees Cook <keescook@...omium.org> Cc: Casey Schaufler <casey@...aufler-ca.com> Cc: Ming Lei <ming.lei@...onical.com> Cc: Takashi Iwai <tiwai@...e.de> Cc: Vojtěch Pavlík <vojtech@...e.cz> Cc: Kyle McMartin <kyle@...nel.org> Cc: Matthew Garrett <mjg59@...f.ucam.org> Cc: linux-kernel@...r.kernel.org Signed-off-by: Luis R. Rodriguez <mcgrof@...e.com> --- drivers/base/firmware_class.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c index 894bda114224..f97e76cca069 100644 --- a/drivers/base/firmware_class.c +++ b/drivers/base/firmware_class.c @@ -353,15 +353,15 @@ static int fw_get_filesystem_firmware(struct device *device, rc = fw_read_file_contents(file, buf); fput(file); if (rc) - dev_warn(device, "firmware, attempted to load %s, but failed with error %d\n", - path, rc); + dev_warn(device, "system data, attempted to load %s, but failed with error %d\n", + path, rc); else break; } __putname(path); if (!rc) { - dev_dbg(device, "firmware: direct-loading firmware %s\n", + dev_dbg(device, "system data: direct-loading firmware %s\n", buf->fw_id); mutex_lock(&fw_lock); set_bit(FW_STATUS_DONE, &buf->status); @@ -1051,7 +1051,7 @@ _request_firmware_prepare(struct firmware **firmware_p, const char *name, } if (fw_get_builtin_firmware(firmware, name)) { - dev_dbg(device, "firmware: using built-in firmware %s\n", name); + dev_dbg(device, "system data: using built-in system data%s\n", name); return 0; /* assigned */ } -- 2.3.2.209.gd67f9d5.dirty -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists