linux-kernel - Re: [PATCH 2/2] ARM: dts: Fix power off method on exynos5422-odroidxu3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 5 Aug 2015 12:54:30 +0200
From:	Javier Martinez Canillas <javier@....samsung.com>
To:	Krzysztof Kozlowski <k.kozlowski.k@...il.com>,
	Sangbeom Kim <sbkim73@...sung.com>,
	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	Lee Jones <lee.jones@...aro.org>, linux-kernel@...r.kernel.org,
	linux-samsung-soc@...r.kernel.org, devicetree@...r.kernel.org,
	Kukjin Kim <kgene@...nel.org>,
	linux-arm-kernel@...ts.infradead.org
Cc:	Anand Moon <linux.amoon@...il.com>
Subject: Re: [PATCH 2/2] ARM: dts: Fix power off method on
 exynos5422-odroidxu3

Hello Krzysztof,

On 08/03/2015 02:37 PM, Krzysztof Kozlowski wrote:
> The Odroid XU3 family boards have ACOKB pin of PMIC grounded, instead of
> pulled up as usual. This means that PMIC must manually set PWRHOLD field
> in its CTRL1 register to low before initiating power down.
> 
> This fixes Odroid XU3 powering off:
> [   25.966053] reboot: Power down
> [   25.967679] Power down.
> [   26.070174] Power down failed, please power off system manually.
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski.k@...il.com>
> Reported-by: Anand Moon <linux.amoon@...il.com>
> ---
>  arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
> index 1565667e6f69..48cecc8cf26e 100644
> --- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
> @@ -159,6 +159,7 @@
>  		s2mps11,buck2-ramp-enable = <1>;
>  		s2mps11,buck3-ramp-enable = <1>;
>  		s2mps11,buck4-ramp-enable = <1>;
> +		samsung,s2mps11-acokb-ground;
>  
>  		interrupt-parent = <&gpx0>;
>  		interrupts = <4 IRQ_TYPE_EDGE_FALLING>;
> 

Reviewed-by: Javier Martinez Canillas <javier@....samsung.com>

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/