linux-kernel - Re: [PATCH 1/7] phy: ti-pipe3: cleanup ti_pipe3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 5 Aug 2015 19:38:08 +0530
From:	Kishon Vijay Abraham I <kishon@...com>
To:	<balbi@...com>
CC:	<rogerq@...com>, <tony@...mide.com>, <t-kristo@...com>,
	<devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linux-usb@...r.kernel.org>, <linux-omap@...r.kernel.org>,
	<nsekhar@...com>
Subject: Re: [PATCH 1/7] phy: ti-pipe3: cleanup ti_pipe3_probe()

Hi,

On Tuesday 04 August 2015 09:30 PM, Felipe Balbi wrote:
> On Tue, Aug 04, 2015 at 08:50:40PM +0530, Kishon Vijay Abraham I wrote:
>> No functional change. Add separate functions for pll,
>> clocks and syscon to make ti_pipe3_probe clean.
>>
>> Signed-off-by: Kishon Vijay Abraham I <kishon@...com>
> 
> I think this needs to be splitted into smaller patches.

yeah sure.

Thanks
Kishon

> 
> Seems like the very first patch would be to introduce a local struct
> device pointer to be used. Than add each and every new function on their
> own patch. This will help big time making your refactoring a lot clearer
> and, should anything go wrong, we can atomically revert a specific
> change, instead of loosing the entire refactor.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/