linux-kernel - Re: [PATCH v2] ioatdma: fix overflow of u16 in ring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPcyv4hXiU5=4cQM-mhKA-YpZWTBwqDLbYbY19RmOPXFNDGShQ@mail.gmail.com>
Date:	Wed, 5 Aug 2015 13:03:52 -0700
From:	Dan Williams <dan.j.williams@...el.com>
To:	Allen Hubbe <Allen.Hubbe@....com>
Cc:	Dave Jiang <dave.jiang@...el.com>,
	"dmaengine@...r.kernel.org" <dmaengine@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] ioatdma: fix overflow of u16 in ring_reshape

On Wed, Aug 5, 2015 at 7:55 AM, Allen Hubbe <Allen.Hubbe@....com> wrote:
> If the allocation order is 16, then the u16 index will overflow and wrap
> to zero instead of being equal or greater than 1 << 16.  The loop
> condition will always be true, and the loop will run until all the
> memory resources are depleted.
>
> Change the type of index 'i' to u32, so that it is large enough to store
> a value equal or greater than 1 << 16.
>
> Signed-off-by: Allen Hubbe <Allen.Hubbe@....com>
> ---
>
> Version Two: rebased the fix on top of Dave Jiang's work.
>

Hmm, I think we should instead limit the max order to 15 instead
because there are other usages of u16 throughout the driver.  In fact
I thought that was already enforced, but seems I'm mistaken.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/