linux-kernel - Re: [PATCH v3 5/9] VMware balloon: Show capabilities of balloon and resulting capabilities in the debug-fs node.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150805201459.GA16009@kroah.com>
Date:	Wed, 5 Aug 2015 13:14:59 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	"Philip P. Moltmann" <moltmann@...are.com>
Cc:	dmitry.torokhov@...il.com, linux-kernel@...r.kernel.org,
	xdeguillard@...are.com, akpm@...ux-foundation.org,
	pv-drivers@...are.com
Subject: Re: [PATCH v3 5/9] VMware balloon: Show capabilities of balloon and
 resulting capabilities in the debug-fs node.

On Fri, Jun 12, 2015 at 11:43:26AM -0700, Philip P. Moltmann wrote:
> This helps with debugging vmw_balloon behavior, as it is clear what
> functionality is enabled.
> 
> Acked-by: Andy King <acking@...are.com>
> Signed-off-by: Xavier Deguillard <xdeguillard@...are.com>
> ---
>  drivers/misc/vmw_balloon.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/vmw_balloon.c b/drivers/misc/vmw_balloon.c
> index 72247d9..6eaf7f7 100644
> --- a/drivers/misc/vmw_balloon.c
> +++ b/drivers/misc/vmw_balloon.c
> @@ -46,7 +46,7 @@
>  
>  MODULE_AUTHOR("VMware, Inc.");
>  MODULE_DESCRIPTION("VMware Memory Control (Balloon) Driver");
> -MODULE_VERSION("1.3.2.0-k");
> +MODULE_VERSION("1.3.3.0-k");

This constant change of module version is annoying, is it really even
needed?

I'll take this, but seriously consider just dropping it entirely as it
doesn't mean anything now that the driver is in the kernel tree.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/