linux-kernel - Re: [PATCH] driver core: bus: Free the kobject.name if kset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150806000120.GA25419@kroah.com>
Date:	Wed, 5 Aug 2015 17:01:20 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Chen Lin Z <lin.z.chen@...el.com>
Cc:	linux-kernel@...r.kernel.org, bo.he@...el.com,
	yanmin_zhang@...ux.intel.com
Subject: Re: [PATCH] driver core: bus: Free the kobject.name if kset_register
 fails

On Tue, Jun 09, 2015 at 05:05:21PM +0800, Chen Lin Z wrote:
> if register two bus with the same name, kset_register will fail.
> it need free kobject.name, otherwise there is a memory leak.
> 
> Signed-off-by: Chen Lin Z <lin.z.chen@...el.com>
> ---
>  drivers/base/bus.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/base/bus.c b/drivers/base/bus.c
> index 79bc203..9375048 100644
> --- a/drivers/base/bus.c
> +++ b/drivers/base/bus.c
> @@ -894,8 +894,10 @@ int bus_register(struct bus_type *bus)
>  	priv->drivers_autoprobe = 1;
>  
>  	retval = kset_register(&priv->subsys);
> -	if (retval)
> +	if (retval) {
> +		kfree(priv->subsys.kobj.name);

This doesn't solve the problem properly, as all of the other error paths
also need to free this memory.

And I really hate to poke around this "deep" into the kobject core, but
I understand it's needed here :(

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/