linux-kernel - RE: [RFC] sdhci: fix DMA leaks [was: [SHDCI] Heavy (thousands) DMA leaks]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BY1PR03MB1388AE95AA9000BB9B8B47559A740@BY1PR03MB1388.namprd03.prod.outlook.com>
Date:	Thu, 6 Aug 2015 09:17:22 +0000
From:	Chen Bough <Haibo.Chen@...escale.com>
To:	Jiri Slaby <jslaby@...e.cz>, Ulf Hansson <ulf.hansson@...aro.org>
CC:	"linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
	"Linux kernel mailing list" <linux-kernel@...r.kernel.org>
Subject: RE: [RFC] sdhci: fix DMA leaks [was: [SHDCI] Heavy (thousands) DMA
 leaks]

I will format a patch based on your diff file firstly. I will test this on my side,
If any issue, like dma issue or performance issue, I will add some modification.
Then I will send the patch for review, and you can test the patch on your platform.

Best Regards
Haibo Chen


> -----Original Message-----
> From: Jiri Slaby [mailto:jslaby@...e.cz]
> Sent: Thursday, August 06, 2015 5:07 PM
> To: Chen Haibo-B51421; Ulf Hansson
> Cc: linux-mmc@...r.kernel.org; Linux kernel mailing list
> Subject: Re: [RFC] sdhci: fix DMA leaks [was: [SHDCI] Heavy (thousands)
> DMA leaks]
> 
> On 08/06/2015, 09:42 AM, Chen Bough wrote:
> > I read your attached log and patch, yes, dma memory leak will happen
> > when more than one pre_request execute. The method of ++next->cookie
> > is not good, your patch seems good, but I still need some time to test
> > the patch, because you unmap the dma in sdhci_finish_data rather than
> the sdhci_post_req.
> 
> Hi,
> 
> yes, this is not correct. We can perhaps differentiate according to the
> COOKIE value. Should I fix it or are you going to prepare a patch based
> on my RFC?
> 
> thanks,
> --
> js
> suse labs