linux-kernel - Re: [PATCH 1/2] Input: atmel_mxt_ts - Implement support for T100 touch object

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1438859498.3362.12.camel@collabora.co.uk>
Date:	Thu, 06 Aug 2015 13:11:38 +0200
From:	Sjoerd Simons <sjoerd.simons@...labora.co.uk>
To:	Dirk Behme <dirk.behme@...bosch.com>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Javier Martinez Canillas <javier@....samsung.com>
Cc:	Henrik Rydberg <rydberg@...omail.se>,
	Nick Dyer <nick.dyer@...ev.co.uk>,
	Doug Anderson <dianders@...omium.org>,
	Olof Johansson <olof@...om.net>,
	Yufeng Shen <miletus@...omium.org>,
	Benson Leung <bleung@...omium.org>,
	Chung-yih Wang <cywang@...omium.org>,
	"linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] Input: atmel_mxt_ts - Implement support for T100
 touch object

+ Corrected Javiers e-mail address. 
On Thu, 2015-08-06 at 12:51 +0200, Dirk Behme wrote:
> On 17.03.2015 15:00, Javier Martinez Canillas wrote:
> > 
> Having this patch in mainline as commit 
> b23157dc74272ac8ebffd1a566e3e822dbc3e65f [1] breaks our Atmel touch.
> 
> It seems that above
> 
> +	set_bit(EV_ABS, input_dev->evbit);
> 
> is missing in the version which went into mainline? Re-adding it 
> makes 
> it work for us, again.
> 
> Opinions?

In mainline the EV_ABS bit automatically gets set as soon as
input_set_abs_params get called. 

If you're using this patch on an older kernel you should backport
2c9a9cfec04f2c6ed7b4e607cd53ca903b2c4642 as well.

-- 
Sjoerd Simons
Collabora Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/