linux-kernel - [PATCH v2] Staging: unisys: visornic: Use kcalloc instead of kzalloc.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1438860341-15248-1-git-send-email-shraddha.6596@gmail.com>
Date:	Thu,  6 Aug 2015 16:55:41 +0530
From:	Shraddha Barke <shraddha.6596@...il.com>
To:	Benjamin Romer <benjamin.romer@...sys.com>,
	David Kershner <david.kershner@...sys.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Neil Horman <nhorman@...hat.com>,
	Tim Sell <Timothy.Sell@...sys.com>, sparmaintainer@...sys.com,
	linux-kernel@...r.kernel.org
Cc:	Shraddha Barke <shraddha.6596@...il.com>
Subject: [PATCH v2] Staging: unisys: visornic: Use kcalloc instead of kzalloc.

This patch converts kzalloc to kcalloc. The advantage of kcalloc is, 
that will take care of integer overflows which could result from the 
multiplication and it is also nicer to read.

The change was made using Coccinelle.

Signed-off-by: Shraddha Barke <shraddha.6596@...il.com>
---
Changes in v2;
  -Make commit message clearer.

 drivers/staging/unisys/visornic/visornic_main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/unisys/visornic/visornic_main.c b/drivers/staging/unisys/visornic/visornic_main.c
index 2a9b055..e4a7b9b5 100644
--- a/drivers/staging/unisys/visornic/visornic_main.c
+++ b/drivers/staging/unisys/visornic/visornic_main.c
@@ -1843,8 +1843,8 @@ static int visornic_probe(struct visor_device *dev)
 		goto cleanup_netdev;
 	}
 
-	devdata->rcvbuf = kzalloc(sizeof(struct sk_buff *) *
-				  devdata->num_rcv_bufs, GFP_KERNEL);
+	devdata->rcvbuf = kcalloc(devdata->num_rcv_bufs,
+				  sizeof(struct sk_buff *), GFP_KERNEL);
 	if (!devdata->rcvbuf) {
 		err = -ENOMEM;
 		goto cleanup_rcvbuf;
-- 
2.1.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/