linux-kernel - Re: [RFC PATCH 0/8] Add Analogix Core Display Port Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55C3769F.2010405@rock-chips.com>
Date:	Thu, 6 Aug 2015 23:00:47 +0800
From:	Yakir Yang <ykk@...k-chips.com>
To:	Jingoo Han <jingoohan1@...il.com>,
	'Heiko Stuebner' <heiko@...ech.de>,
	'Russell King' <rmk+kernel@....linux.org.uk>,
	'Fabio Estevam' <fabio.estevam@...escale.com>,
	'Inki Dae' <inki.dae@...sung.com>
Cc:	djkurtz@...gle.com, dianders@...gle.com,
	'Takashi Iwai' <tiwai@...e.de>,
	'Andrzej Hajda' <a.hajda@...sung.com>,
	'Thierry Reding' <treding@...dia.com>,
	'Philipp Zabel' <p.zabel@...gutronix.de>,
	'David Airlie' <airlied@...ux.ie>,
	'Gustavo Padovan' <gustavo.padovan@...labora.co.uk>,
	'Seung-Woo Kim' <sw0312.kim@...sung.com>,
	'Kyungmin Park' <kyungmin.park@...sung.com>,
	'Krzysztof Kozlowski' <k.kozlowski@...sung.com>,
	'Kukjin Kim' <kgene@...nel.org>,
	'Ajay Kumar' <ajaykumar.rs@...sung.com>,
	'Joonyoung Shim' <jy0922.shim@...sung.com>,
	'Vincent Palatin' <vpalatin@...omium.org>,
	'Mark Yao' <mark.yao@...k-chips.com>,
	'Andy Yan' <andy.yan@...k-chips.com>,
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
	linux-samsung-soc@...r.kernel.org,
	linux-rockchip@...ts.infradead.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [RFC PATCH 0/8] Add Analogix Core Display Port Driver

Jingoo,

在 2015/8/6 22:41, Jingoo Han 写道:
> On Thursday, August 06, 2015 10:49 PM, Yakir Yang wrote:
>> Hi all,
>>     Samsung exynos and Rockchip rk3288 almost share same dp controller,
>> so I split the common code out, then rk3288 and exynos can re-used the
>> same dp core driver. Cause I can't find the exact IP name of exynos dp
>> controller, so I decide to name dp core driver with "analogix" which I
>> find in rk3288 eDP TRM ;)
>
> OK, I see.
> The Samsung Exynos eDP contoller and Rockchip rk3288 eDP contoller share
> the same IP. So, a lot of parts can be re-used. I agree with this.
> However, we have to review the code carefully, as others did.
Yeah, feel happy to be reviewed  ;)

> I also cannot find the exact IP name. The "analogix" may be the vendor name
> of this IP.
Okay, so "analogix" is okay for now

Thanks,
- Yakir
> Best regards,
> Jingoo Han
>
>> Beyond that, there are three light registers setting differents bewteen
>> exynos and rk3288.
>> 1. RK3288 have five special pll resigters which not indicata in exynos
>>     dp controller.
>> 2. The address of DP_PHY_PD(dp phy power manager register) are different
>>     between rk3288 and exynos.
>> 3. Rk3288 and exynos have different setting with AUX_HW_RETRY_CTL(dp debug
>>     register).
>>
>> My series patches can be divider into two parts: One for spliting the
>> analogix_dp code from exynos dp driver. Another are trying to add rk3288
>> dp driver support.
>>
>> Best regards,
>> - Yakir
>>
>>
>> --
>> 2.1.2
>
>
>
>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/