linux-kernel - Re: [PATCH] ARM: Mark ret_fast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.20.1508061327510.1515@knanqh.ubzr>
Date:	Thu, 6 Aug 2015 13:30:40 -0400 (EDT)
From:	Nicolas Pitre <nicolas.pitre@...aro.org>
To:	Drew Richardson <drew.richardson@....com>
cc:	"linux@....linux.org.uk" <linux@....linux.org.uk>,
	Dave P Martin <Dave.Martin@....com>,
	"christoffer.dall@...aro.org" <christoffer.dall@...aro.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Wade Cherry <Wade.Cherry@....com>,
	Pawel Moll <pawel.moll@....com>
Subject: Re: [PATCH] ARM: Mark ret_fast_syscall as a function

On Thu, 6 Aug 2015, Drew Richardson wrote:

> On Tue, Jul 14, 2015 at 01:45:57PM +0100, Drew Richardson wrote:
> > ret_fast_syscall runs when user space makes a syscall. However it
> > needs to be marked as such so the ELF information is correct. Before
> > it was:
> > 
> >    101: 8000f300     0 NOTYPE  LOCAL  DEFAULT    2 ret_fast_syscall
> > 
> > But with this change it correctly shows as:
> > 
> >    101: 8000f300    96 FUNC    LOCAL  DEFAULT    2 ret_fast_syscall
> > 
> > I see this function when using perf to unwind call stacks from kernel
> > space to user space. Without this change I would need to add some
> > special case logic when using the vmlinux ELF information.
> > 
> > Signed-off-by: Drew Richardson <drew.richardson@....com>
> 
> I haven't heard any further comments on this, did this get merged and
> I just didn't notice? Or did I forget to add someone?

Most likely that it is so trivial that nobody paid much attention.

FWIW, you can add

Acked-by: Nicolas Pitre <nico@...aro.org>

and submit it here: http://www.arm.linux.org.uk/developer/patches/


Nicolas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/