linux-kernel - Re: [PATCH V5] audit: use macros for unset inode and device values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150806034034.GA18741@madcap2.tricolour.ca>
Date:	Wed, 5 Aug 2015 23:40:34 -0400
From:	Richard Guy Briggs <rgb@...hat.com>
To:	Paul Moore <pmoore@...hat.com>
Cc:	linux-audit@...hat.com, linux-kernel@...r.kernel.org,
	sgrubb@...hat.com, eparis@...hat.com
Subject: Re: [PATCH V5] audit: use macros for unset inode and device values

On 15/08/05, Paul Moore wrote:
> On Wednesday, August 05, 2015 04:19:09 PM Richard Guy Briggs wrote:
> > Clean up a number of places were casted magic numbers are used to represent
> > unset inode and device numbers in preparation for the audit by executable
> > path patch set.
> > 
> > Signed-off-by: Richard Guy Briggs <rgb@...hat.com>
> > ---
> > v5: Move macros from include/uapi/linux/audit.h to include/linux/audit.h
> >     Use "unsigned int" rather than bare "unsigned".
> > 
> >  include/linux/audit.h |    3 +++
> >  kernel/audit.c        |    2 +-
> >  kernel/audit_watch.c  |    8 ++++----
> >  kernel/auditsc.c      |    6 +++---
> >  4 files changed, 11 insertions(+), 8 deletions(-)
> > 
> > diff --git a/include/linux/audit.h b/include/linux/audit.h
> > index c2e7e3a..48ae90c 100644
> > --- a/include/linux/audit.h
> > +++ b/include/linux/audit.h
> > @@ -27,6 +27,9 @@
> >  #include <linux/ptrace.h>
> >  #include <uapi/linux/audit.h>
> > 
> > +#define AUDIT_INO_UNSET (unsigned long)-1
> > +#define AUDIT_DEV_UNSET (unsigned int)-1
> 
> I suspect it was lost in the noise when I mentioned it on v4, but how about 
> changing AUDIT_DEV_UNSET to "(dev_t)-1"?

I saw your comment only after resubmitting.  I'm fine either way.  If it
is needed for uapi later it can be changed then.  Is it easy to change
in your workflow, or should I resubmit?  I know you routinely change the
patch description, but could not remember if you have actually changed
the patch itself...

> paul moore

- RGB

--
Richard Guy Briggs <rbriggs@...hat.com>
Senior Software Engineer, Kernel Security, AMER ENG Base Operating Systems, Red Hat
Remote, Ottawa, Canada
Voice: +1.647.777.2635, Internal: (81) 32635, Alt: +1.613.693.0684x3545
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/