linux-kernel - [PATCH] checkpatch: Don't complain about long "Fixes:" lines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1438832648-31761-1-git-send-email-mpe@ellerman.id.au>
Date:	Thu,  6 Aug 2015 13:44:08 +1000
From:	Michael Ellerman <mpe@...erman.id.au>
To:	<linux-kernel@...r.kernel.org>, apw@...onical.com, joe@...ches.com
Subject: [PATCH] checkpatch: Don't complain about long "Fixes:" lines

We encourage people to mention the commit they are fixing, if any, using
a Fixes line, see SubmittingPatches.

Although it's not mentioned explicitly, it's preferable if the Fixes
line is not wrapped, so skip Fixes lines when checking for overlength
lines.

Signed-off-by: Michael Ellerman <mpe@...erman.id.au>
---
 scripts/checkpatch.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index d5c8e9a3a73c..b3139cb1bf9d 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2310,7 +2310,7 @@ sub process {
 
 # Check for line lengths > 75 in commit log, warn once
 		if ($in_commit_log && !$commit_log_long_line &&
-		    length($line) > 75) {
+		    length($line) > 75 && $line !~ /^\s*Fixes: [0-9a-f]+/i) {
 			WARN("COMMIT_LOG_LONG_LINE",
 			     "Possible unwrapped commit description (prefer a maximum 75 chars per line)\n" . $herecurr);
 			$commit_log_long_line = 1;
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/