linux-kernel - Re: [PATCH v3 3/3] iTCO_wdt: Add support for TCO on Intel Sunrisepoint

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 6 Aug 2015 23:08:17 +0200
From:	Wolfram Sang <wsa@...-dreams.de>
To:	Matt Fleming <matt@...eblueprint.co.uk>
Cc:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Wim Van Sebroeck <wim@...ana.be>,
	linux-kernel@...r.kernel.org, linux-watchdog@...r.kernel.org,
	Mika Westerberg <mika.westerberg@...ux.intel.com>,
	Jean Delvare <jdelvare@...e.com>,
	Lee Jones <lee.jones@...aro.org>,
	Guenter Roeck <linux@...ck-us.net>,
	Matt Fleming <matt.fleming@...el.com>
Subject: Re: [PATCH v3 3/3] iTCO_wdt: Add support for TCO on Intel
 Sunrisepoint

On Thu, Aug 06, 2015 at 01:00:24PM +0100, Matt Fleming wrote:
> (Sorry for the delay in replying)
> 
> On Fri, 31 Jul, at 11:41:04AM, Andy Shevchenko wrote:
> > >  
> > > +	if (val32 & enable_bit)
> > > +		ret = -EIO;
> > > +
> > >  	return ret; /* returns: 0 = OK, -EIO = Error */
> > 
> > What about removing ret at all?
> > 
> > if (val32 & enable_bit)
> >  return -EIO;
> > 
> > return 0;
>  
> Yeah, good catch. I'll make this change.

I'd go for the ternary operator here.


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)