linux-kernel - Re: [PATCH 07/13] twl4030_charger: distinguish between USB current and 'AC' current

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150807031116.GH4215@atomide.com>
Date:	Thu, 6 Aug 2015 20:11:16 -0700
From:	Tony Lindgren <tony@...mide.com>
To:	NeilBrown <neil@...wn.name>
Cc:	Sebastian Reichel <sre@...nel.org>,
	Samuel Ortiz <sameo@...ux.intel.com>, linux-pm@...r.kernel.org,
	David Woodhouse <dwmw2@...radead.org>,
	linux-kernel@...r.kernel.org,
	real GTA04 owners <gta04-owner@...delico.com>,
	Dmitry Eremin-Solenikov <dbaryshkov@...il.com>,
	Pavel Machek <pavel@....cz>, linux-omap@...r.kernel.org,
	Lee Jones <lee.jones@...aro.org>
Subject: Re: [PATCH 07/13] twl4030_charger: distinguish between USB current
 and 'AC' current

* NeilBrown <neil@...wn.name> [150729 17:28]:
> --- a/drivers/power/twl4030_charger.c
> +++ b/drivers/power/twl4030_charger.c
>  static int twl4030_charger_update_current(struct twl4030_bci *bci)
>  {
>  	int status;
> +	int cur;
>  	unsigned reg, cur_reg;
>  	u8 bcictl1, oldreg, fullreg;
>  	bool cgain = false;
>  	u8 boot_bci;
>  
> +	/*
> +	 * If AC (Accessory Charger) voltage exceeds 4.5V (MADC 11)
> +	 * and AC is enabled, set current for 'ac'
> +	 */
> +	if (twl4030_get_madc_conversion(11) > 4500) {
> +		cur = bci->ac_cur;
> +		bci->ac_is_active = true;
> +	} else {
> +		cur = bci->usb_cur;
> +		bci->ac_is_active = false;
> +	}
> +
>  	/* First, check thresholds and see if cgain is needed */
>  	if (bci->ichg_eoc >= 200000)
>  		cgain = true;

Neil, you need a stub or something for twl4030_get_madc_conversion
if madc is not selected. Now at least omap2plus_defconfig and
ARM allmodconfig fails in Linux next.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/