linux-kernel - Re:[PATCH] mips: Fix console output for Fulong2e system

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tencent_37A9E5F5514586140D3774A8@qq.com>
Date:	Fri, 7 Aug 2015 14:12:41 +0800
From:	"陈华才" <chenhc@...ote.com>
To:	"Guenter Roeck" <linux@...ck-us.net>,
	"Ralf Baechle" <ralf@...ux-mips.org>
Cc:	"linux-mips" <linux-mips@...ux-mips.org>,
	"linux-kernel" <linux-kernel@...r.kernel.org>,
	"Guenter Roeck" <linux@...ck-us.net>
Subject: Re:[PATCH] mips: Fix console output for Fulong2e system

Acked-by: Huacai Chen <chenhc@...ote.com>
 
------------------ Original ------------------
From:  "Guenter Roeck"<linux@...ck-us.net>;
Date:  Fri, Aug 7, 2015 01:57 PM
To:  "Ralf Baechle"<ralf@...ux-mips.org>; 
Cc:  "Huacai Chen"<chenhc@...ote.com>; "linux-mips"<linux-mips@...ux-mips.org>; "linux-kernel"<linux-kernel@...r.kernel.org>; "Guenter Roeck"<linux@...ck-us.net>; 
Subject:  [PATCH] mips: Fix console output for Fulong2e system

 
Commit 3adeb2566b9b ("MIPS: Loongson: Improve LEFI firmware interface")
made the number of UARTs dynamic if LEFI_FIRMWARE_INTERFACE is configured.
Unfortunately, it did not initialize the number of UARTs if
LEFI_FIRMWARE_INTERFACE is not configured. As a result, the Fulong2e
system has no console.

Fixes: 3adeb2566b9b ("MIPS: Loongson: Improve LEFI firmware interface")
Cc: Huacai Chen <chenhc@...ote.com>
Signed-off-by: Guenter Roeck <linux@...ck-us.net>
---
Never mind my earlier e-mail, I figured it out.
Should be a candidate for stable (v3.19+, ie v4.1 in practice).

 arch/mips/loongson64/common/env.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/mips/loongson64/common/env.c b/arch/mips/loongson64/common/env.c
index f6c44dd332e2..d6d07ad56180 100644
--- a/arch/mips/loongson64/common/env.c
+++ b/arch/mips/loongson64/common/env.c
@@ -64,6 +64,9 @@ void __init prom_init_env(void)
 	}
 	if (memsize == 0)
 		memsize = 256;
+
+	loongson_sysconf.nr_uarts = 1;
+
 	pr_info("memsize=%u, highmemsize=%u\n", memsize, highmemsize);
 #else
 	struct boot_params *boot_p;
-- 
2.1.4