linux-kernel - Re: [PATCH] irqchip: gic-v3: Explicitly include linux/io.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55C46EE3.9050307@arm.com>
Date:	Fri, 07 Aug 2015 09:40:03 +0100
From:	Marc Zyngier <marc.zyngier@....com>
To:	Ben Zhang <benzh@...omium.org>,
	Thomas Gleixner <tglx@...utronix.de>
CC:	Jason Cooper <jason@...edaemon.net>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] irqchip: gic-v3: Explicitly include linux/io.h

Hi Ben,

On 07/08/15 06:31, Ben Zhang wrote:
> linux/io.h is needed because the driver uses:
> readl_relaxed
> writel_relaxed
> writeq_relaxed
> readq_relaxed
> iounmap
> 
> The header was implicitly included by an unrelated
> commit 332fd7c4fef5
> ("genirq: Generic chip: Change irq_reg_{readl,writel} arguments")
> from the path below:
> include/linux/io.h
> include/linux/irq.h
> include/linux/of_irq.h
> drivers/irqchip/irq-gic-v3.c
> 
> Signed-off-by: Ben Zhang <benzh@...omium.org>
> ---
>  drivers/irqchip/irq-gic-v3.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c
> index e406bc5..3350b8d 100644
> --- a/drivers/irqchip/irq-gic-v3.c
> +++ b/drivers/irqchip/irq-gic-v3.c
> @@ -19,6 +19,7 @@
>  #include <linux/cpu_pm.h>
>  #include <linux/delay.h>
>  #include <linux/interrupt.h>
> +#include <linux/io.h>
>  #include <linux/of.h>
>  #include <linux/of_address.h>
>  #include <linux/of_irq.h>
> 

This seems valid, but out of curiosity: Has this triggered any
observable build failure? Or is that something you found by inspection?

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/