linux-kernel - Re: [PATCH] kvm:s390:Fix assumption that kvm_set_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <55C475B3.1080303@de.ibm.com>
Date:	Fri, 07 Aug 2015 11:09:07 +0200
From:	Christian Borntraeger <borntraeger@...ibm.com>
To:	Nicholas Krause <xerofoify@...il.com>, gleb@...nel.org
CC:	pbonzini@...hat.com, cornelia.huck@...ibm.com, linux390@...ibm.com,
	kvm@...r.kernel.org, linux-s390@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kvm:s390:Fix assumption that kvm_set_irq_routing is always
 run successfully

Am 06.08.2015 um 19:05 schrieb Nicholas Krause:
> This fixes the assumption that kvm_set_irq_routing is always run
> successfully by instead making it equal to the variable r which
> we use for returning in the function kvm_arch_vm_ioctl instead
> of making r equal to zero when calling this particular function
> and incorrectly making the caller of kvm_arch_vm_ioctl think
> the function has run successfully.
> 
> Signed-off-by: Nicholas Krause <xerofoify@...il.com>
> ---
>  arch/s390/kvm/kvm-s390.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
> index f32f843..660860f 100644
> --- a/arch/s390/kvm/kvm-s390.c
> +++ b/arch/s390/kvm/kvm-s390.c
> @@ -879,8 +879,7 @@ long kvm_arch_vm_ioctl(struct file *filp,
>  		if (kvm->arch.use_irqchip) {
>  			/* Set up dummy routing. */
>  			memset(&routing, 0, sizeof(routing));
> -			kvm_set_irq_routing(kvm, &routing, 0, 0);
> -			r = 0;
> +			r = kvm_set_irq_routing(kvm, &routing, 0, 0);
>  		}
>  		break;
>  	}
> 

Thanks, applied with changed prefix (KVM: s390:)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/