linux-kernel - Re: [PATCH] kvm:powerpc:Fix error handling in the function mpic_set_default_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <55C485CD.4040708@redhat.com>
Date:	Fri, 7 Aug 2015 12:17:49 +0200
From:	Paolo Bonzini <pbonzini@...hat.com>
To:	Nicholas Krause <xerofoify@...il.com>, agraf@...e.com
Cc:	gleb@...nel.org, kvm-ppc@...r.kernel.org, kvm@...r.kernel.org,
	linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kvm:powerpc:Fix error handling in the function
 mpic_set_default_irq_routing



On 06/08/2015 19:13, Nicholas Krause wrote:
> diff --git a/arch/powerpc/kvm/mpic.c b/arch/powerpc/kvm/mpic.c
> index 6249cdc..5a18859 100644
> --- a/arch/powerpc/kvm/mpic.c
> +++ b/arch/powerpc/kvm/mpic.c
> @@ -1641,13 +1641,16 @@ static void mpic_destroy(struct kvm_device *dev)
>  static int mpic_set_default_irq_routing(struct openpic *opp)
>  {
>  	struct kvm_irq_routing_entry *routing;
> +	int ret;
>  
>  	/* Create a nop default map, so that dereferencing it still works */
>  	routing = kzalloc((sizeof(*routing)), GFP_KERNEL);
>  	if (!routing)
>  		return -ENOMEM;
>  
> -	kvm_set_irq_routing(opp->kvm, routing, 0, 0);
> +	ret = kvm_set_irq_routing(opp->kvm, routing, 0, 0);
> +	if (ret)
> +		return ret;
>  
>  	kfree(routing);
>  	return 0;

The patch leaks the "routing" variable if you hit the error path.

Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/