lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20150807142737.GA31997@saruman.tx.rr.com>
Date:	Fri, 7 Aug 2015 09:27:38 -0500
From:	Felipe Balbi <balbi@...com>
To:	Robert Baldyga <r.baldyga@...sung.com>
CC:	<balbi@...com>, <gregkh@...uxfoundation.org>,
	<linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] usb: musb: gadget: fix build break by adding missing
 'break'

On Fri, Aug 07, 2015 at 02:13:34PM +0200, Robert Baldyga wrote:
> Add missing break after 'default' label to fix compilation error.
> 
> Signed-off-by: Robert Baldyga <r.baldyga@...sung.com>

the funny thing is that this doesn't break with ARM build:

$ make ARCH=arm drivers/usb/musb/
  CHK     include/config/kernel.release
  CHK     include/generated/uapi/linux/version.h
  UPD     include/config/kernel.release
  CHK     include/generated/utsrelease.h
  UPD     include/generated/utsrelease.h
make[1]: 'include/generated/mach-types.h' is up to date.
  CHK     include/generated/timeconst.h
  CHK     include/generated/bounds.h
  CHK     include/generated/asm-offsets.h
  CALL    scripts/checksyscalls.sh
  LD      drivers/usb/musb/built-in.o
  CC [M]  drivers/usb/musb/musb_core.o
  CC [M]  drivers/usb/musb/musb_virthub.o
  CC [M]  drivers/usb/musb/musb_host.o
  CC [M]  drivers/usb/musb/musb_gadget_ep0.o
  CC [M]  drivers/usb/musb/musb_gadget.o
  CC [M]  drivers/usb/musb/musb_debugfs.o
  CC [M]  drivers/usb/musb/omap2430.o
  CC [M]  drivers/usb/musb/musb_dsps.o
  CC [M]  drivers/usb/musb/musb_am335x.o
  CC [M]  drivers/usb/musb/am35x.o
  CC [M]  drivers/usb/musb/sunxi.o
  CC [M]  drivers/usb/musb/tusb6010.o
  CC [M]  drivers/usb/musb/ux500.o
  LD [M]  drivers/usb/musb/musb_hdrc.o

oh well :-p

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ