linux-kernel - Re: [PATCH 2/2] gadget: Support for the usb charger framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150807175317.GD10003@kroah.com>
Date:	Fri, 7 Aug 2015 10:53:17 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Baolin Wang <baolin.wang@...aro.org>
Cc:	Peter Chen <Peter.Chen@...escale.com>, Felipe Balbi <balbi@...com>,
	Mark Brown <broonie@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	"sojka@...ica.cz" <sojka@...ica.cz>,
	Alan Stern <stern@...land.harvard.edu>,
	"andreas@...sler.com" <andreas@...sler.com>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>
Subject: Re: [PATCH 2/2] gadget: Support for the usb charger framework

On Fri, Aug 07, 2015 at 05:22:47PM +0800, Baolin Wang wrote:
> On 7 August 2015 at 17:07, Peter Chen <Peter.Chen@...escale.com> wrote:
> >
> >> >>  /**
> >> >>   * struct usb_udc - describes one usb device controller @@ -127,12
> >> >> +128,45 @@ void usb_gadget_giveback_request(struct usb_ep *ep,  }
> >> >> EXPORT_SYMBOL_GPL(usb_gadget_giveback_request);
> >> >>
> >> >> +int usb_gadget_register_notify(struct usb_gadget *gadget,
> >> >> +                            struct notifier_block *nb) {
> >> >> +     unsigned long flags;
> >> >> +     int ret;
> >> >> +
> >> >> +     spin_lock_irqsave(&gadget->lock, flags);
> >> >
> >> > I find you use so many spin_lock_irqsave, any reasons for that?
> >> > Why mutex_lock can't be used?
> >> >
> >>
> >> The spin_lock_irqsave() can make it as a atomic notifier, that can make sure the
> >> gadget state event can be quickly reported to the user who register a notifier
> >> on the gadget device. Is it OK?
> >>
> >
> > I don't think it is a good reason, spin_lock_irqsave is usually used for protecting
> > data which is accessed at atomic environment.
> >
> 
> Yes, we want the notify process is a atomic environment which do not
> want to be interrupted by irq or other things to make the notice can
> be quickly reported to the user.

No, this is a "slow" event, you don't need to notify anyone under atomic
context, that's crazy.

> Also i think the notify process is less cost, thus i use the spinlock. Thanks.

No, use a mutex please, that's the safe thing.  This is not
time-critical code at all.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/