linux-kernel - Re: [PATCH] usb: hcd.h: Fix the values of SetHubDepth and GetPortErrorCount to match USB 3.1 specification

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 7 Aug 2015 11:07:11 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Tal Shorer <tal.shorer@...il.com>
Cc:	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: hcd.h: Fix the values of SetHubDepth and
 GetPortErrorCount to match USB 3.1 specification

On Fri, Aug 07, 2015 at 08:52:25PM +0300, Tal Shorer wrote:
> >From the usb 3.1 spec available at http://www.usb.org/developers/docs/
> table 10-7 (Hub Class Requests) specifies the values for SetHubDepth and
> GetPortErrorCount as:
> 
> Request bmRequestType bRequest wValue wIndex wLength Data
> SetHubDepth 00100000B SET_HUB_DEPTH Hub Depth Zero Zero None
> GetPortErrorCount 10100011B GET_PORT_ERR_COUNT Zero Port Two Number of Link
> 	Errors on this port
> 
> Fix these two values to match the spec.
> 
> Signed-off-by: Tal Shorer <tal.shorer@...il.com>
> ---
>  include/linux/usb/hcd.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/include/linux/usb/hcd.h b/include/linux/usb/hcd.h
> index c9aa779..6a24416 100644
> --- a/include/linux/usb/hcd.h
> +++ b/include/linux/usb/hcd.h
> @@ -564,9 +564,9 @@ extern void usb_ep0_reinit(struct usb_device *);
>  
>  /*-------------------------------------------------------------------------*/
>  
> -/* class requests from USB 3.0 hub spec, table 10-5 */
> -#define SetHubDepth		(0x3000 | HUB_SET_DEPTH)
> -#define GetPortErrorCount	(0x8000 | HUB_GET_PORT_ERR_COUNT)
> +/* class requests from USB 3.1 hub spec, table 10-7 */
> +#define SetHubDepth (0x2000 | HUB_SET_DEPTH)
> +#define GetPortErrorCount (0xa300 | HUB_GET_PORT_ERR_COUNT)

Why did you loose the indentation?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/