linux-kernel - Re: [PATCH] regmap: Remove useless check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150807182730.GL10301@sirena.org.uk>
Date:	Fri, 7 Aug 2015 19:27:30 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Salah Triki <salah.triki@....org>
Cc:	gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] regmap: Remove useless check

On Fri, Aug 07, 2015 at 06:33:36PM +0100, Salah Triki wrote:
> lzo1x_1_do_compress always returns LZO_E_OK. Thus, the check of the
> return value is useless.

No, if you want to do this then you should be fixing the LZO API to
remove the returned value - if a value is being returned it's always
good practice to pay attention to that, not doing that because the
current implementation happens to have some behaviour just makes the
code more fragile if someone comes along and changes the implementation.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)