linux-kernel - Re: [Patch v3] usb: hcd.h: Fix the values of SetHubDepth and GetPortErrorCount to match USB 3.1 specification

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150807193048.GA14107@kroah.com>
Date:	Fri, 7 Aug 2015 12:30:48 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Tal Shorer <tal.shorer@...il.com>
Cc:	USB list <linux-usb@...r.kernel.org>,
	"<linux-kernel@...r.kernel.org>" <linux-kernel@...r.kernel.org>
Subject: Re: [Patch v3] usb: hcd.h: Fix the values of SetHubDepth and
 GetPortErrorCount to match USB 3.1 specification

On Fri, Aug 07, 2015 at 09:48:19PM +0300, Tal Shorer wrote:
> On Fri, Aug 7, 2015 at 9:40 PM, Greg KH <gregkh@...uxfoundation.org> wrote:
> > On Fri, Aug 07, 2015 at 09:16:00PM +0300, Tal Shorer wrote:
> >> >From the usb 3.1 spec available at http://www.usb.org/developers/docs/
> >> table 10-7 (Hub Class Requests) specifies the values for SetHubDepth and
> >> GetPortErrorCount as:
> >>
> >> Request bmRequestType bRequest wValue wIndex wLength Data
> >> SetHubDepth 00100000B SET_HUB_DEPTH Hub Depth Zero Zero None
> >> GetPortErrorCount 10100011B GET_PORT_ERR_COUNT Zero Port Two Number of Link Errors on this port
> >
> > Still does not look correct to me, how about you?
> >
> 
> Not sure what you mean. This is a simple copy-paste from the spec document.
> Do you want me to put quotation marks around the multi-word Data column?

I want the columns to line up so that they look sane and someone can
understand what they mean :)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/