linux-kernel - [RT - hwlat_detector] correctly record max when the "outer" value is maximum

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20150807152037.02884401@sluggy>
Date:	Fri, 7 Aug 2015 15:20:37 -0500
From:	Clark Williams <williams@...hat.com>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	Steven Rostedt <srostedt@...hat.com>,
	LKML <linux-kernel@...r.kernel.org>,
	RT <linux-rt-users@...r.kernel.org>,
	Luiz Capitulino <lcapitulino@...hat.com>
Subject: [RT - hwlat_detector] correctly record max when the "outer" value
 is maximum

Steven,

The hwlat_detector module does not correctly record when the "outer"
calculation is the largest diff seen in consecutive clock reads. This
patch should properly record when outer_sample is the largest value
seen:
>From 8b9c14ea45991fdda2040d45647ca4d5358e8221 Mon Sep 17 00:00:00 2001
From: Clark Williams <williams@...hat.com>
Date: Fri, 7 Aug 2015 15:07:30 -0500
Subject: [PATCH] hwlat_detector: update stats code to record when "outer" interval exceeds threshold

The hwlat_detector polls the system clock (either ktime_get() or trace_clock_local())
source looking for intervals between successive reads which exceed a specified threshold.
There are two intervals examined, the "inner" interval which is between t1 and t2,
and the "outer" interval which is between t2 and t1' (i.e. the "next" t1 value).

This patch updates the detector module to record if the outer interval is the maximum
interval encountered during a run.

Reported-by: Luiz Capitulino <lcapitulino@...hat.com>
Signed-off-by: Clark Williams <williams@...hat.com>
---
 drivers/misc/hwlat_detector.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/misc/hwlat_detector.c b/drivers/misc/hwlat_detector.c
index d2676b867e41..5ca7aa9780e0 100644
--- a/drivers/misc/hwlat_detector.c
+++ b/drivers/misc/hwlat_detector.c
@@ -294,6 +294,8 @@ static int get_sample(void)
 		/* Keep a running maximum ever recorded hardware latency */
 		if (sample > data.max_sample)
 			data.max_sample = sample;
+		if (outer_sample > data.max_sample)
+			data.max_sample = outer_sample;
 	}
 
 out:
-- 
2.4.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/