linux-kernel - Re: [PULL] clockevents: a couple of fixes for tip/timers/urgent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdVu08M3R+hpt+VkTb_SoX8sNdYGMNz9B9gqYerw-=eFOA@mail.gmail.com>
Date:	Fri, 7 Aug 2015 23:25:40 +0200
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Ingo Molnar <mingo@...nel.org>
Cc:	Daniel Lezcano <daniel.lezcano@...aro.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PULL] clockevents: a couple of fixes for tip/timers/urgent

On Fri, Aug 7, 2015 at 9:19 AM, Ingo Molnar <mingo@...nel.org> wrote:
>> Maxime Coquelin (1):
>>       clockevents/drivers/timer-stm32: Improve dependencies of timer-stm32
>>
>>  drivers/clocksource/Kconfig  | 4 ++--
>
> Hm, so why is this an urgent fix, i.e. a regression fix? It appears to widen build
> coverage:
>
>  config CLKSRC_STM32
> -       bool "Clocksource for STM32 SoCs" if !ARCH_STM32
> -       depends on OF && ARM && (ARCH_STM32 || COMPILE_TEST)
> +       bool "Clocksource for STM32 SoCs" if COMPILE_TEST
> +       depends on OF && GENERIC_CLOCKEVENTS
>
> that can at most introduce build regressions - not fix anything.
>
> If there's any other purpose of this change it's not mentioned in the changelog.
>
> Also, I think the change is broken to begin with:
>
> +       bool "Clocksource for STM32 SoCs" if COMPILE_TEST
>
> this will turn off the driver even in its target platform!

FWIW, ARCH_STM32 in arch/arm/Kconfig selects CLKSRC_STM32

> The right way to increase testing this way is via:
>
>         depends on ... || COMPILE_TEST

Indeed.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/