lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 8 Aug 2015 12:27:28 +0100 From: Jonathan Cameron <jic23@...nel.org> To: Daniel Baluta <daniel.baluta@...il.com>, Pengyu Ma <pengyu.ma@...driver.com> Cc: Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org> Subject: Re: [PATCH V2] iio: declare struct to fix warning On 04/08/15 09:14, Daniel Baluta wrote: > On Tue, Aug 4, 2015 at 11:11 AM, Pengyu Ma <pengyu.ma@...driver.com> wrote: >> >> >> On 08/04/2015 04:03 PM, Daniel Baluta wrote: >>> >>> On Mon, Aug 3, 2015 at 5:39 AM, Pengyu Ma <pengyu.ma@...driver.com> wrote: >>>> >>>> When compile iio related driver the following warning shown: >>>> >>>> include/linux/iio/trigger.h:35:34: warning: 'struct iio_trigger' >>>> declared inside parameter list >>>> int (*set_trigger_state)(struct iio_trigger *trig, bool state); >>>> >>>> include/linux/iio/trigger.h:38:18: warning: 'struct iio_dev' >>>> declared inside parameter list >>>> struct iio_dev *indio_dev); >>>> >>>> 'struct iio_dev' and 'struct iio_trigger' was used before declaration, >>>> forward declaration for these structs to fix warning. >>>> >>>> Signed-off-by: Pengyu Ma <pengyu.ma@...driver.com> >>>> --- >>>> include/linux/iio/trigger.h | 4 ++++ >>>> 1 file changed, 4 insertions(+) >>>> >>>> diff --git a/include/linux/iio/trigger.h b/include/linux/iio/trigger.h >>>> index fa76c79..974cf73 100644 >>>> --- a/include/linux/iio/trigger.h >>>> +++ b/include/linux/iio/trigger.h >>>> @@ -18,6 +18,10 @@ struct iio_subirq { >>>> bool enabled; >>>> }; >>>> >>>> +/* forward declaration */ >>> >>> I would remove this comment. It doesn't says much. >> >> OK, Do I need a v3 review or you apply it with your modification directly? > > Please send v3, Jonathan will appreciate this :). I will indeed ;) Thanks, > > thanks, > Daniel. > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@...r.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists