linux-kernel - sparse bogus unexpected unlock warning? untag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Sat, 8 Aug 2015 10:39:00 -0400
From:	Richard Guy Briggs <rgb@...hat.com>
To:	linux-audit@...hat.com, linux-kernel@...r.kernel.org
Cc:	Paul Moore <pmoore@...hat.com>, Eric Paris <eparis@...hat.com>,
	Al Viro <viro@...IV.linux.org.uk>
Subject: sparse bogus unexpected unlock warning? untag_chunk

After adding "C=1 CF=-D__CHECK_ENDIAN__" to my build script, sparse
produced the following warning:
	kernel/audit_tree.c:222:13: warning: context imbalance in 'untag_chunk' - unexpected unlock

It looks like a confused parser to me, because the locks appear to
balance properly from my review.

It doesn't say which lock triggered the warning, hash_lock, or
entry->lock.  The hash_lock is locked on call and returns in the same
state.  entry->lock looks fine.  The fsnotify marks look get/put
balanced too.

Is sparse spewing bogons, or am I?

- RGB

--
Richard Guy Briggs <rbriggs@...hat.com>
Senior Software Engineer, Kernel Security, AMER ENG Base Operating Systems, Red Hat
Remote, Ottawa, Canada
Voice: +1.647.777.2635, Internal: (81) 32635, Alt: +1.613.693.0684x3545
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/