lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Sat, 08 Aug 2015 01:55:02 -0500
From:	Junsu Shin <jjunes0@...il.com>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>,
	mchehab@....samsung.com, gregkh@...uxfoundation.org
CC:	devel@...verdev.osuosl.org, boris.brezillon@...e-electrons.com,
	linux-kernel@...r.kernel.org, prabhakar.csengg@...il.com,
	hans.verkuil@...co.com, laurent.pinchart@...asonboard.com,
	s.nawrocki@...sung.com, linux-media@...r.kernel.org
Subject: Re: [PATCH 1/1] Staging: media: davinci_vpfe: fix over 80 characters
 coding style issue.


On 08/06/2015 11:45 PM, Sudip Mukherjee wrote:
> On Thu, Aug 06, 2015 at 09:55:54PM -0500, Junsu Shin wrote:
>>  This is a patch to the dm365_ipipe.c that fixes over 80 characters warning detected by checkpatch.pl.
>>  Signed-off-by: Junsu Shin <jjunes0@...il.com>
> please do not use whitespace before Signed-off-by: line.
>>
>> ---
>>  drivers/staging/media/davinci_vpfe/dm365_ipipe.c | 5 +++--
>>  1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
>> index 1bbb90c..57cd274 100644
>> --- a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
>> +++ b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
>> @@ -1536,8 +1536,9 @@ ipipe_get_format(struct v4l2_subdev *sd, struct v4l2_subdev_pad_config *cfg,
>>   * @fse: pointer to v4l2_subdev_frame_size_enum structure.
>>   */
>>  static int
>> -ipipe_enum_frame_size(struct v4l2_subdev *sd, struct v4l2_subdev_pad_config *cfg,
>> -			  struct v4l2_subdev_frame_size_enum *fse)
>> +ipipe_enum_frame_size(struct v4l2_subdev *sd,
>> +			struct v4l2_subdev_pad_config *cfg,
>> +			struct v4l2_subdev_frame_size_enum *fse)
> since you are modifying this line, please fix up the indention also.
> 
> regards
> sudip
> 

Thanks for pointing it out.
Again, this is a patch to the dm365_ipipe.c that fixes over 80 characters warning detected by the script.
This time I fixed up the indentation issue claimed in the previous one.
Signed-off-by: Junsu Shin <jjunes0@...il.com>
---
 drivers/staging/media/davinci_vpfe/dm365_ipipe.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
index 1bbb90c..a474adf 100644
--- a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
+++ b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
@@ -1536,8 +1536,9 @@ ipipe_get_format(struct v4l2_subdev *sd, struct v4l2_subdev_pad_config *cfg,
  * @fse: pointer to v4l2_subdev_frame_size_enum structure.
  */
 static int
-ipipe_enum_frame_size(struct v4l2_subdev *sd, struct v4l2_subdev_pad_config *cfg,
-			  struct v4l2_subdev_frame_size_enum *fse)
+ipipe_enum_frame_size(struct v4l2_subdev *sd,
+		       struct v4l2_subdev_pad_config *cfg,
+		       struct v4l2_subdev_frame_size_enum *fse)
 {
 	struct vpfe_ipipe_device *ipipe = v4l2_get_subdevdata(sd);
 	struct v4l2_mbus_framefmt format;
-- 
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists